Skip to content

Custom Route Resolvers #2415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

Custom Route Resolvers #2415

wants to merge 40 commits into from

Conversation

posva
Copy link
Member

@posva posva commented Dec 5, 2024 •
edited
Loading

New version of the internal matcher (renamed as resolver). With more responsibilities and allowing it to be overridden:

  • custom parsing /serializing of params (numbers, dates, classes, etc)
  • matching on the query

@netlify Netlify
Copy link

netlify bot commented Dec 5, 2024 •
edited
Loading

✅ Deploy Preview for vue-router ready!

Name Link
🔨 Latest commit bce9486
🔍 Latest deploy log https://app.netlify.com/projects/vue-router/deploys/687a77c9c801ee00087f09d2
😎 Deploy Preview https://deploy-preview-2415--vue-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🟢 up 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 5, 2024 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/vue-router@2415

commit: bce9486

@codecov Codecov
Copy link

codecov bot commented Dec 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 31.93277% with 810 lines in your changes missing coverage. Please review.

Project coverage is 76.68%. Comparing base (6a11243) to head (bce9486).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/router/src/experimental/router.ts 0.00% 611 Missing and 1 partial ⚠️
...s/router/src/new-route-resolver/resolver-static.ts 0.00% 104 Missing and 1 partial ⚠️
packages/router/src/new-route-resolver/resolver.ts 77.77% 54 Missing ⚠️
...uter/src/new-route-resolver/matchers/test-utils.ts 70.83% 21 Missing ⚠️
...s/router/src/new-route-resolver/matcher-pattern.ts 81.25% 12 Missing ⚠️
...s/router/src/new-route-resolver/matchers/errors.ts 54.54% 5 Missing ⚠️
packages/router/src/new-route-resolver/index.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2415       +/-   ##
===========================================
- Coverage   94.90%   76.68%   -18.23%     
===========================================
  Files          34       42        +8     
  Lines        3002     4130     +1128     
  Branches      846      920       +74     
===========================================
+ Hits         2849     3167      +318     
- Misses        150      957      +807     
- Partials        3        6        +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@posva posva mentioned this pull request Jan 16, 2025
Closed
@huang-julien huang-julien mentioned this pull request Mar 1, 2025
Open
@posva posva changed the title New Matcher with param parsing Custom Route Resolvers Mar 20, 2025
@vitebo vitebo mentioned this pull request May 21, 2025
Closed
4 tasks
@github-project-automation github-project-automation bot moved this to 🆕 Triaging in Vue Router Roadmap Jul 15, 2025
@posva posva moved this from 🆕 Triaging to 🧑‍💻 In progress in Vue Router Roadmap Jul 15, 2025
@posva posva mentioned this pull request Jul 15, 2025
Closed
@posva posva force-pushed the feat/new-matcher branch from db5a85c to ef995f4 Compare July 16, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Vue Router Roadmap
Status: 🧑‍💻 In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@posva